Knights and Merchants.net Forum

Today I managed to update Hungarian translation in order to match the current version, but since then the application has been randomly crashing. There are no multiple keys added and none omitted. Please revise what is responsible for any malfunction in the attached text: i couldn't find any. Trouble is very likely out of a serious disorder in the game engine, concerning text processing.

Thanks in advance for your help.

EDIT: File updated!

What have you exactly updated? I'm curious.

More than 100 strings hadn't been translated at all: most of them connected to the Map Editor module. Some lines of the translated text didn't fit to the containing area, others had faults of spelling, or just weren't expressive enough. There are still many English strings that hasn't yet been exported for translation, some of them are very old, for example "has quit": these should be addressed by the development team.

Just pick and extract the attachment from my former post, and replace "Kam Remake\data\text\text.hun.libx" with it. You should make a backup of the original one, since this may still contain unintentional bugs that may be responsible for some recent game crashes.

Yeah I know how to update it, but since I can't see the older one I can't point out what you have corrected/updated
Good job though.

Please attach crash messages that you get.

Here you go.

Oh and... you'd be welcome to including my translation in the next patch.

I was referring to either a screenshot or a full crashreport (which would show where exactly the StackOverflow occurred).

The log says you got a StackOverflow error, which is hardly related with games texts, they don't affect in-games logic.

What made you think that updated texts are the root of the problem in the first place?

Windows 8 doesn't inform me of anything on crashes except for the bare event itself. In the first version of my translation I missed a line feed at the end of the last row, when new keys had to be added. Stack overflow could be a result of infinitely reading the last row, if the reading algorithm is a loop of "read until delimiter" instructions. In C++ this is a common issue because end of file is post-checked. In Pascal EOF is pre-checked so while the issue may be present, shouldn't by all means result in a stack overflow, but one can never know. An appropriate text processing code should dissemble the task for character processing, thus EOF check is executable regardless of a presence of a delimiter after the last semantic data.

You mean that the game silently blanks out, no error message displayed at all?

I have tested removing of last EOL and that did not lead to a crash. The game loads text files on startup, if there's anything wrong with the data the crash would happen immediately (e.g. MaxID = 40245846056+). If texts loaded then they are probably fine (worst case the single text entry is monstrously long, which is ruled out by EOLs anyway).

All that makes me believe your crashes were caused by something unrelated.

If you do have a reproduceable crash scenario, please let us know.

*Reproduceable crash means that you can tell exact steps to 100% reproduce the crash. E.g. use your libx, open MapEd, open Army tab = crash.

Crash is not silent but Windows only tells me "KaM Remake has stopped functioning" and doesn't give me access to any kind of dump or any further information. And no, crash didn't happen on loadup, but during a multiplayer game, so I don't actually intend to frequently reproduce this bug, unless I want to be banned for all lobbies in the future.

You can create MP game with just AI players for your tests.