@Pawel: Thanks, I will test it again. If I can't reproduce it by myself I'll go on TeamSpeak and ask for your expert advice on how to break it
EDIT: I can't reproduce it. I fixed a bug report you sent in (crash when trying to select a save). Did the bug with neither player being host happen soon after this bug? They could be related. If anybody wants to help me test this talk to me on TeamSpeak. The more players I have to test it the better
(testing by myself running two copies don't work as well as with multiple people).
Name OnPlanField and OnPlanWinefield need to be swapped, now OnPlanField is for Vinefield xDD
Fixed, thank you
Now i have more crashes than before when i copy landscape (tooken from the same map) to an other position. i sended the crash-reports, so that you know it more detailed.
While looking at your report I found a few other errors/crashes to do with copying terrain and fixed them. Thanks for sending the report
Its a kinda old bug, after this (its in Event OnHouseDestroy):
- Code:
Actions.HouseDestroy(aHouseID, true);
Actions.GiveHouse(AI_DUMMY, t, x, y);
the created house lost his "way block", and you can cross house with units easily.
without Actions.HouseDestroy(aHouseID, true); next script GiveHouse doesnt work and ddint give any log ( in HouseDestroy event)
OnHouseDestroyed happens before the house is actually destroyed so you can still access states like HouseType, HouseOwner, etc. (you can't access those things after the house is destroyed). That's why GiveHouse doesn't work, the original house is still in the way (it is silently ignored because at the moment errors are only logged for invalid parameters like house type 999, not for invalid placement like another house being in the way). Putting Actions.HouseDestroy(aHouseID, true); in OnHouseDestroyed should get you into an infinite loop (and eventually stack overflow) because it will keep calling OnHouseDestroyed again and again.... I guess you had some kind of check to prevent that.
Destroying the house in OnHouseDestroyed will cause mistakes (miscounted statistics amongst other things) and could cause crashes. Therefore I'll make it so HouseDestroy is ignored within OnHouseDestroy for the house itself (destroying other houses is fine of course). We are aiming for scripts to fail immediately rather than cause mistakes that might make the game crash later (for example by counting a house destroyed twice in statistics).
OnUnitKilled and OnHouseDestroyed were never designed as "
Now this entity is gone and you can replace it with something else". They were designed as "
This entity is about to be destroyed, do you want to do anything before I wipe it from the game and the ID becomes invalid?". But I can see the use in replacing something as soon as it is destroyed. Maybe we need two more events OnHouseAfterDestroyed and OnUnitAfterKilled(Type, Owner, X, Y: Integer); which would be called after they have been completely wiped from the game so you could replace them with something, but because of this they could not provide you with an ID to use states like HouseType (although I guess they could still provide the ID so you can compare it with variables you have saved, but states like HouseType wouldn't work). Do you think this would be a good solution?
These kind of issues are one of the reasons why UnitKill doesn't work instantly. Within certain events killing the unit instantly will cause errors in the game (for example killing Attacker in OnHouseDamage would cause a problem since that unit is still processing its house attack task, and adding checks to handle any set of circumstances like these would make our code very messy and impossible to maintain).
