Map Database  •  FAQ  •  RSS  •  Login

Does it make sense to dump legacy win/defeat conditions ?

<<

Krom

User avatar

Knights Province Developer

Posts: 3280

Joined: 09 May 2006, 22:00

KaM Skill Level: Fair

Location: Russia

Post 25 Feb 2015, 12:47

Does it make sense to dump legacy win/defeat conditions ?

Since KaM Remake scripting is so advanced now, do you think it makes sense to dump legacy KaM victory/defeat conditions from static map script?

I mean ADD_GOAL and ADD_LOST_GOAL which are responsible for:
  Code:
gc_BuildTutorial: Result := True; //Deprecated //gc_Time is disabled as we process messages in Event system now. Return true so players //do not have to wait for all messages to show before they are allowed to win (same in TPR) gc_Time: Result := True; //Deprecated gc_Buildings: Result := (Stat.GetHouseQty([ht_Store, ht_School, ht_Barracks]) > 0); gc_Troops: Result := (Stat.GetArmyCount > 0); gc_MilitaryAssets: Result := (Stat.GetArmyCount > 0) or (Stat.GetHouseQty([ht_Barracks, ht_CoalMine, ht_WeaponWorkshop, ht_ArmorWorkshop, ht_Stables, ht_IronMine, ht_IronSmithy ,ht_WeaponSmithy, ht_ArmorSmithy, ht_TownHall, ht_SiegeWorkshop]) > 0); gc_SerfsAndSchools: Result := (Stat.GetHouseQty([ht_School]) > 0) or (Stat.GetUnitQty(ut_Serf) > 0); gc_EconomyBuildings: Result := (Stat.GetHouseQty([ht_Store, ht_School, ht_Inn]) > 0);
For the standard win/defeat conditions KMR could save template dynamic script file and place a template win and defeat script text into it.
Knights Province at: http://www.knightsprovince.com
KaM Remake at: http://www.kamremake.com
Original MBWR/WR2/AFC/FVR tools at: http://krom.reveur.de
<<

Vatrix

User avatar

Council Member

Posts: 410

Joined: 19 Apr 2013, 20:30

KaM Skill Level: Veteran

Location: Czech Republic

Post 25 Feb 2015, 15:08

Re: Does it make sense to dump legacy win/defeat conditions

I don't think it's a good idea, dynamic scripts should still be taken as an extension for static scripts. Also I'm a bit lazy, so it's easier to have basic win conditions in static scripts (I just love static scripts :$ ).

Only thing I would like to change is to remove "None", "Build tutorial", "Time" and "Unknown" conditions, because I like things polished.

Also a little off-topic:
I think it's a bug; when you set AI attack type to "closest unit", they attack civil units also, which has a bad side effects sometimes, it would be better if AI attack just army.
I fixed The Shattered Kingdom and The Peasants Rebellion here!
<<

Ben

User avatar

Former Site Admin

Posts: 3814

Joined: 08 Jan 2009, 23:00

Location: California - Pacific Time (UTC -8/-7 Summer Time)

Post 25 Feb 2015, 20:15

Re: Does it make sense to dump legacy win/defeat conditions

I say dump most of the commands. Serfs&schools, Economy buildings, military buildings&troops, tutorial-- these are quite silly to have around, as they are very specific and such "complicated" goals can be met a lot better with scripts.

In fact, the only goal(s) we really need are the default goals for mutiplayer (important buildings/troops)
I used to spam this forum so much...
<<

Vatrix

User avatar

Council Member

Posts: 410

Joined: 19 Apr 2013, 20:30

KaM Skill Level: Veteran

Location: Czech Republic

Post 25 Feb 2015, 21:40

Re: Does it make sense to dump legacy win/defeat conditions

But, but...
Serfs and schools are needed for TSK 19 and military buildings are needed for TPR 4.
I fixed The Shattered Kingdom and The Peasants Rebellion here!
<<

Krom

User avatar

Knights Province Developer

Posts: 3280

Joined: 09 May 2006, 22:00

KaM Skill Level: Fair

Location: Russia

Post 26 Feb 2015, 05:06

Re: Does it make sense to dump legacy win/defeat conditions

I agree with Vatrix, those "complicated" goals are nice to keep for TSK, but I also agree with Ben - new maps hardly ever need them. Stalemate.
Knights Province at: http://www.knightsprovince.com
KaM Remake at: http://www.kamremake.com
Original MBWR/WR2/AFC/FVR tools at: http://krom.reveur.de
<<

The Dark Lord

User avatar

King Karolus Servant

Posts: 2154

Joined: 29 Aug 2007, 22:00

KaM Skill Level: Veteran

Location: In his dark thunderstormy castle

Post 26 Feb 2015, 15:51

Re: Does it make sense to dump legacy win/defeat conditions

What would be a good reason to dump them? All I see is extra work...
<<

Ben

User avatar

Former Site Admin

Posts: 3814

Joined: 08 Jan 2009, 23:00

Location: California - Pacific Time (UTC -8/-7 Summer Time)

Post 26 Feb 2015, 16:29

Re: Does it make sense to dump legacy win/defeat conditions

For me removing them seems to be the "cleaner" option. It seems ambigious to new users as to why some(most) complicated goals must be entered with dynamic scripts and a few goals can be done in game.

I mean I don't care either way. I won't lose sleep over it, but removing them seems to make more sense. It would be more work in a few rare cases, but perhaps it's worth the effort?
I used to spam this forum so much...

Return to “Dynamic Scripting”

Who is online

Users browsing this forum: No registered users and 9 guests